Simple Invoices - Forum

I've had a little spare time this morning and done a fresh install of si 2010 beta3 but still get the same problem. The version I was using above is si 2010.1

hey scunthorpe fan

yep - tested and is an issue

will fix up now

cheers

justin

Thanks Justin, will this be a code fix that I / other users can implement on existing SI 2010.1 ? Many thanks.

the changes can be applied to 2010.1

refer: http://code.google.com/p/simpleinvoices/source/detail?r=2930 for the files and changes needed to fix this issue

will be in Simple Invoices 2010.2 beta 5

cheers

justin

I've implemented the code changes but the Invoice Amount is still showing as £9 not £10.

Gross £8.51 Correct
VAT £1.49 Correct
Invoice Amount £9.00 Incorrect

(After editing the files and making the code changes ncessary do I need to do anything else?)

I have found that if I enter the item quantity as 2 the total is still only wrong by £1 (this is true of any quantity I add)

Gross £17.02 correct
VAT £2.98 correct
Invoice Amount £19.00 incorrect by £1

Justin, as this is now marked as closed, and the actual bug is now with" Invoice Total", should I start a new thread? Thanks

hey scunnyutd

with the adjusted code i tried using your example product cost of 8.510638 and 17.% tax and recorded as $10

i'll do a new 'beta' release of Simple Invoices later this week some time 2010.2 beta 5 - will include this code

once its released, please download and retest - hopefully will work OK for you

cheers

justin

I think this is related to: http://simpleinvoices.org/forum/discussion/732/tax-issue/#Item_14

The issue seems to be with how the rounding is/isn't done for tax calculation. Generally if a tax calculation is done on an amount that exceeds 2 decimals the value of the 3rd decimal value will be used to round the 2nd decimal value upward if the 3rd decimal value is >=5.

So for a tax calculated equaling $5.9051 this should equal $5.91 with rounding

I am not sure how far down you should go. For example if you have a calculated tax of $5.90451. Then should this equal the same $5.91 because the 4th decimal 5 would round the 3rd decimal 4 to 5, which then rounds the 2nd decimal to a 1?

mrembedded It isn't specifically related to the rounding of the decimal point. If it were the figure would be wrong by 1 pence either way. The actual error on a £8.51 (whatever decimal places..) is that tax is actually calculated correct but the invoice total misses a whole £1 off. Item £8.51, Tax @ 17.5% = £1.49 = Total should = £10, instead it equals £9. Subsequent items and quantities on the same invoice all calculate and add up correctly. It is just an issue with the very first calculation on the first £8.51 sale.

I will await Justins Beta 5 and update you. (Maybe the issue was fixed with the code update and I have implemented something wrong? we shall see!)

i'll try and get beta 5 released in the next few days

will put up a demo once it out - so we can test online

cheers

justin

Hi Justin, Not sure what version the online demo is running at the moment? (Perhaps this could be denoted on the page?)

On the demo, I have just added a tax rate of 17.5% and a product @ £8.5106, invoice total is still $9 and not $10, The tax is showing correctly though. I will download and install beta 5 tomorrow when i'm back in work. If you haven't updated the online demo yet to beta 5 then please disregard / delete this response!

Many thanks for all your hard work.

the demo site has now been upgrade to 2010.2 beta 5, try your 17.5% tax rate example there and let us know how you go

note: the db gets reset every hour

cheers

justin

Hi Justin,

Exactly the same i'm afraid. Item @ 8.51, Tax displayed as 1.49, invoice total at 9.00 and not 10.00. Its on the demo site as we speak. Thanks

thanks

yep - see it in action now

i;ve disabled the auto-db-refresh thing on the demo site

will try and get this fixed up asap

cheers

justin

hey scunnyutd

can you try on the demo site again

i've updated the Zend Framework we use to 1.10.4 and it seems to have fixed the problem

if it works - you can download the latest Zend Framework and extract the Zend folder in our ./library folder
- or wait till the next beta

cheers

justin

Justin,

Confirmed working. Downloaded and replaced ./library/Zend folder with 1.10.4

Thanks for a terrific product, and and even better product support.

All the best

scunnyutd

great to hear its working!!!

was freaking out that i made some crazy ass mistake re rounding - but looks to be an issue with the Zend Framework

by the way, how this scunthorpe united going this season - any chance for promotion?

cheers

justin

We finished 2 places above relegation (20th out of 24)! However, we are in the second tier of english football which is a lofty height for such a small team! So, overall it was a very successful season :)

good to hear you guys didnt get relegated

cheers

justin

Hai Justin.,

This is Mubarak. Could you tell me how to change the $ values into Indian rupees. and how can i give some priviliges to user's like admin can access all those things. but user only acccess some restricted pages. how is posssible in simple invoices.

Anyine Could known that issue. pls let me know asap. I'm critical situation.

Thanks in more advance,

hey mubarak

re $
- edit the invoice preferences and change the $ symbol to the rupees symbol or whatever you want

re user rights
- no really possible right now - this part of Simple Invoices is still a work in progress

cheers

justin