Simple Invoices - Forum

Hi there,

I noticed that there some error on reports. For example, the Report TAX - Total Tax is not separating the Real and Draft status of invoices preferences.

Link: http://www.simpleinvoices.org/demo/index.php?module=reports&view=report_tax_total

Example: I have Invoice and Quotes. Since Quotes are set as draft (since there is no REAL transaction yet) I don't want the tax involved on Quotes to be showed on reports.. and all of the others reports.

I change the query on modules/reports/report_tax_total.php and now I think the issue is solved. Please can someone check if this is correct and if yes, maybe this can be fixed on svn for later versions.

The code - before - not working:


<?php
// include phpreports library
require_once("./include/reportlib.php");

$sSQL = "select sum(ii.tax_amount) as sum_tax_total from ".TB_PREFIX."invoice_items ii";

$oRpt->setXML("./modules/reports/report_tax_total.xml");

// include phpreports run code
include("./include/reportrunlib.php");

$smarty -> assign('pageActive', 'report');
$smarty -> assign('active_tab', '#home');
?>

The code - "fixed" - separating real from draft:

<?php
// include phpreports library
require_once("./include/reportlib.php");

$sSQL = "select sum(ii.tax_amount) as sum_tax_total from ".TB_PREFIX."invoice_items ii, ".TB_PREFIX."invoices i, ".TB_PREFIX."preferences p
where
i.preference_id = p.pref_id
and
i.id = ii.invoice_id
and
p.status = '1';
";

$oRpt->setXML("./modules/reports/report_tax_total.xml");

// include phpreports run code
include("./include/reportrunlib.php");

$smarty -> assign('pageActive', 'report');
$smarty -> assign('active_tab', '#home');
?>


Justin, can you confirm that this is the real fix?

BTW: how can I get this fixed on statements? I want to list just the "real" documents. Same for total of products sold.. just want the ones that are on real documents.